[leafnode-list] Re: leafnode 2: "make update" -> "Can't open?groupinfo.old!"

[Adam Funk]

On 2009-04-06, clemens fischer wrote:

> On Mon-2009/04/06-17:53 Adam Funk wrote:

>> $ ./configure  --prefix=/usr/local      --sysconfdir=/etc/news/leafnode2   \
>>               --mandir=/usr/local/man  --localstatedir=/var               \
>>               --enable-runas-user=news --enable-spooldir=/var/spool/news
...
>> But `make update`, running as root, gives me "Error: Can't open
>> groupinfo.old!"; looking through the source code (but with my limited
>> familiarity with C/C++) I suspect that means it can't open
>> groupinfo.old to read it --- and that makes no sense to me, since I'm
>> running it as root.  I may be mistaken, of course.
>
> The "update" target in the Makefile runs the script "update.sh" in the
> source directory, no C/C++ involved here.
>
> To me, the script would first issue "Re-sorting groupinfo file...", then
> rename "${SPOOLDIR}/leaf.node/groupinfo" to "groupinfo.old".  I don't
> understand why there is talk about "${LIBDIR}/groupinfo" and the one in
> ${SPOOLDIR}, it looks like leafnode-1 had this file in ${LIBDIR}, where
> SPOOLDIR is /var/spool/news and LIBDIR is /etc/news/leafnode2 in your
> case.  Was your leafnode-1 configuration directory some place else than
> etc/news/leafnode2?  In that case update.sh wouldn't find groupinfo
> AFAICS.  It seems the script is not suited for a situation other than
> updating in-place.

As you say, my leafnode-1 installation has "/var/spool/news/leaf.node/groupinfo",
which I think is the expected location in leafnode 2.

I think the problem is a combination of the Makefile's update target:

update:
        @./update.sh $(SPOOLDIR) $(sysconfdir) $(SPOOLDIR)/leaf.node/lock.file $(RUNAS_USER) $(RUNAS_GROUP)

and the update.sh script, which refers sometimes to "${SPOOLDIR}/leaf.node/groupinfo"
and sometimes to "${LIBDIR}/groupinfo"; I'm still trying to digest it, but I think 
I can just manually run update.sh with the right parameters.