[leafnode-list] Posting issues with 1.9.52rc??

[Matthias Andree]

William Hooper schrieb am 2004-03-28:

> 
> William Hooper said:
> > I don't post often so I'm not sure when it happened (or if it is an
> > upstream news server issue).  Leafnode is for some reason reporting that I
> > don't have posting permission:
> 
> Just an update, I downgraded to 1.9.51 and posting works.  Any suggestions
> on a particular RC to try and narrow down the issue?

No need, I am seeing the bug. Your upstream replied with an error to MODE
READER and leafnode-1.9.52 uses that error response rather the previous
200 greeting code, as 1.9.51 did.

Please try this patch:

Index: fetchnews.c
===================================================================
RCS file: /var/CVS/leafnode-1/fetchnews.c,v
retrieving revision 1.160
diff -u -r1.160 fetchnews.c
--- fetchnews.c	28 Mar 2004 05:04:57 -0000	1.160
+++ fetchnews.c	28 Mar 2004 22:03:30 -0000
@@ -2406,6 +2406,7 @@
 	fflush(stdout);
 	reply = nntpconnect(current_server);
 	if (reply) {
+	    int r2;
 	    if (verbose) {
 		int namlen = strlen(current_server->name);
 		printf("%s: connected.\n", current_server->name);
@@ -2421,7 +2422,10 @@
 	    }
 	    xsnprintf(lineout, SIZE_lineout, "MODE READER\r\n");
 	    putaline();
-	    reply = nntpreply(current_server);
+
+	    r2 = nntpreply(current_server);
+	    if (r2 < 400) reply = r2;
+
 	    if (reply == 498) {
 		ln_log(LNLOG_SERR, LNLOG_CTOP, "%s: protocol error after sending mode reader",
 		       current_server->name);

-- 
Matthias Andree

Encrypt your mail: my GnuPG key ID is 0x052E7D95