[leafnode-list] Re: [PATCH] WIP: port leafnode-2 to pcre2

[Matthias Andree]

Am 26.03.25 um 22:01 schrieb Matěj Cepl via leafnode-list:
> I tried to port patches from
> https://sourceforge.net/p/leafnode/git/ci/c4738bf3b28bdcdbe7247ceede115594d03e764c/
> and
> https://sourceforge.net/p/leafnode/git/ci/a30371c2dc1c28bbceb4989dd7cf7647461b9ce4/
> but currently I am not even able to run ./configure.

Matěj,

Thanks for your efforts, patch applied & improved upon in a series of 
further commits so we can now configure and compile and pass the trivial 
"make test", but this needs run-time testing. It's called alpha, so...

Regarding configure.ac, config.log is your friend and shows you what 
test program was generated and how it failed to preprocess/compile/link/run.

- the program generator has two arguments, one for header, one for the 
function body. You used three arguments. That confused the test driver, 
it added the #include statement in the main() { /* here */ } and broke 
the test. config.log showed something like nested atoi definition or 
something (on Fedora 41).

- the pcre2_compile_8 function you intended to test for presence has one 
more argument, which you did not pass, so the test failed due to wrong 
argument count, not due to missing function. leafnode-1's test used a 
standard test, for leafnode-2, I have repaired yours.

- I request --libs pcre2-8 from pcre2-config instead of just pcre2, to 
match what the source expects.


All changes including yours compile on Debian testing and Fedora 41, and 
have been pushed to sourceforge and gitlab.

https://gitlab.com/leafnode-2/leafnode-2/-/commits/master?ref_type=heads


Cheers,
Matthias